Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for namespace attribute #6279

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Remove support for namespace attribute #6279

merged 2 commits into from
Jul 19, 2024

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented Jul 18, 2024

Description

Namespace annotation is no longer supported and has been replaced by namespacing syntax.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111
Fix namespace documentation example
f9d51e7 
Namespace annotation is no longer supported and has been replaced by
namespacing syntax.
@IGI-111 IGI-111 requested review from a team as code owners July 18, 2024 16:45
@IGI-111 IGI-111 changed the title Fix namespace documentation example Remove support for namespace attribute Jul 18, 2024
@github-actions GitHub Actions
Copy link

Benchmark for b0ff31f

Click to view benchmark
Test Base PR %
code_action 5.1±0.28ms 5.0±0.02ms -1.96%
code_lens 285.4±7.63ns 318.1±11.51ns +11.46%
compile 2.8±0.04s 2.7±0.05s -3.57%
completion 4.5±0.09ms 4.5±0.06ms 0.00%
did_change_with_caching 2.7±0.05s 2.6±0.03s -3.70%
document_symbol 846.6±14.80µs 933.2±38.96µs +10.23%
format 69.7±1.03ms 69.2±1.00ms -0.72%
goto_definition 341.4±4.86µs 337.6±4.20µs -1.11%
highlight 8.7±0.20ms 8.7±0.17ms 0.00%
hover 491.7±4.32µs 494.0±6.54µs +0.47%
idents_at_position 120.0±0.28µs 121.6±1.07µs +1.33%
inlay_hints 625.9±24.34µs 621.8±23.34µs -0.66%
on_enter 489.2±12.15ns 461.3±12.41ns -5.70%
parent_decl_at_position 3.6±0.10ms 3.5±0.04ms -2.78%
prepare_rename 336.4±5.30µs 337.2±8.66µs +0.24%
rename 8.9±0.11ms 8.9±0.12ms 0.00%
semantic_tokens 1259.2±17.49µs 1261.1±19.68µs +0.15%
token_at_position 333.9±3.62µs 338.8±1.94µs +1.47%
tokens_at_position 3.6±0.03ms 3.5±0.04ms -2.78%
tokens_for_file 400.1±3.74µs 401.8±3.16µs +0.42%
traverse 38.2±0.73ms 38.5±0.69ms +0.79%

@github-actions GitHub Actions
Copy link

Benchmark for f8dc831

Click to view benchmark
Test Base PR %
code_action 5.0±0.03ms 5.0±0.08ms 0.00%
code_lens 289.3±10.01ns 287.0±8.09ns -0.80%
compile 2.7±0.04s 2.6±0.03s -3.70%
completion 4.5±0.09ms 4.5±0.06ms 0.00%
did_change_with_caching 2.6±0.03s 2.6±0.02s 0.00%
document_symbol 940.1±13.92µs 918.7±44.32µs -2.28%
format 68.2±0.97ms 68.6±1.45ms +0.59%
goto_definition 348.1±6.14µs 381.2±23.58µs +9.51%
highlight 8.7±0.12ms 8.7±0.12ms 0.00%
hover 498.6±3.56µs 533.9±11.95µs +7.08%
idents_at_position 120.9±0.30µs 121.7±0.47µs +0.66%
inlay_hints 631.4±26.34µs 631.8±45.18µs +0.06%
on_enter 466.3±12.99ns 460.8±14.10ns -1.18%
parent_decl_at_position 3.6±0.02ms 3.5±0.05ms -2.78%
prepare_rename 332.6±6.37µs 374.5±7.68µs +12.60%
rename 8.9±0.13ms 8.9±0.20ms 0.00%
semantic_tokens 1279.0±6.91µs 1341.8±18.53µs +4.91%
token_at_position 334.1±3.49µs 334.3±1.97µs +0.06%
tokens_at_position 3.6±0.05ms 3.5±0.04ms -2.78%
tokens_for_file 404.6±9.00µs 419.6±8.47µs +3.71%
traverse 37.6±0.48ms 38.4±1.30ms +2.13%

@IGI-111 IGI-111 merged commit e9cdaac into master Jul 19, 2024
39 checks passed
@IGI-111 IGI-111 deleted the IGI-111/namespace branch July 19, 2024 11:54
esdrubal pushed a commit that referenced this pull request Aug 13, 2024
@IGI-111 @esdrubal
Remove support for namespace attribute (#6279)
a76f8e2 
## Description
Namespace annotation is no longer supported and has been replaced by
namespacing syntax.


## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
@Voxelot Voxelot added the breaking May cause existing user code to break. Requires a minor or major release. label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritao tritao tritao approved these changes

@K1-R1 K1-R1 K1-R1 approved these changes

Assignees

@IGI-111 IGI-111

Labels
breaking May cause existing user code to break. Requires a minor or major release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IGI-111 @tritao @K1-R1 @Voxelot